fix: wait for peer ACK in notify and notify_0rtt before returning
#87
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the QUIC CONNECTION_CLOSE frame sent when the caller closes the connection can race with (and arrive before) the stream data at the server, causing the server's accept_bi to see ApplicationClosed instead of the notify message. Call finish() to signal end-of-stream, then stopped().await to wait for the peer's transport-level ACK before returning. This ensures the server has the stream data before the connection is closed. Signed-off-by: Joe Grund <grundjoseph@gmail.com>
matheus23
requested changes
Feb 10, 2026
Member
matheus23
left a comment
matheus23
left a comment
There was a problem hiding this comment.
Thank you so much for looking into this!
Unfortunately, waiting for .stopped().await is not the correct way to ensure all data is sent (as we had to learn the hard way).
But I agree with the spirit of the PR of making sure the connections never get dropped before a request is finished.
One way of making that possible is to use the second stream in a request for signaling, even if the stream itself doesn't have any data sent:
let (mut tx, mut rx) = request.write(msg).await?;
tx.finish()
.map_err(|e| rpc::WriteError::from(quinn::WriteError::from(e)))?;
rx.received_reset()
.await
.map_err(|e| rpc::WriteError::from(quinn::WriteError::from(e)))?;Then the other side of that protocol that answers requests needs to make sure to call tx.finish() when it fully read and processed the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the QUIC CONNECTION_CLOSE frame sent when the caller closes the connection can race with (and arrive before) the stream data at the server, causing the server's accept_bi to see ApplicationClosed instead of the notify message.
Call finish() to signal end-of-stream, then stopped().await to wait for the peer's transport-level ACK before returning. This ensures the server has the stream data before the connection is closed.